Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: ➁ mock consensus can InitChain with two validators #3937

Closed
cratelyn opened this issue Mar 4, 2024 · 1 comment · Fixed by #4174
Closed

tests: ➁ mock consensus can InitChain with two validators #3937

cratelyn opened this issue Mar 4, 2024 · 1 comment · Fixed by #4174
Assignees
@cratelyn
Labels
A-mock-consensus Area: Relates to the mock consensus engine
Milestone
Sprint 4

Comments

@cratelyn
Copy link
Contributor

cratelyn commented Mar 4, 2024

see:

in #3902 we introduced the ability to start a test node with a single set of validator keys. from conversation with @/erwanor, it would be helpful when writing staking tests to provide another interface, allowing us to start a test node with four validators.
@cratelyn cratelyn added the A-mock-consensus Area: Relates to the mock consensus engine label Mar 4, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra Mar 4, 2024
@cratelyn cratelyn mentioned this issue Mar 4, 2024
Closed
@cratelyn cratelyn changed the title tests: ➃ mock consensus can InitChain with four validators tests: ➁ mock consensus can InitChain with two validators Mar 4, 2024
@cratelyn
Copy link
Contributor Author

cratelyn commented Mar 4, 2024

we want to be able to test certain scenarios where one val get tombstoned, so two validators are sufficient (i think four came from talking about 3f+1)

update from @erwanor

cratelyn added a commit that referenced this issue Apr 8, 2024
@cratelyn
mock-consensus: 🫛 two_validators adds two keys
70b8c8e 
fixes #3937.

* #3937
* #3588

this adds a `two_validators` method to the test node builder, so that
tests may set up a test node that has two validator keys.
cratelyn added a commit that referenced this issue Apr 8, 2024
@cratelyn
mock-consensus: 🫛 two_validators adds two keys
7a7d51c 
fixes #3937.

* #3937
* #3588

this adds a `two_validators` method to the test node builder, so that
tests may set up a test node that has two validator keys.
@cratelyn cratelyn mentioned this issue Apr 8, 2024
Merged
1 task
@cratelyn cratelyn moved this from Backlog to In progress in Penumbra Apr 8, 2024
@cratelyn cratelyn added this to the Sprint 4 milestone Apr 8, 2024
@cratelyn cratelyn self-assigned this Apr 8, 2024
cratelyn added a commit that referenced this issue Apr 9, 2024
@cratelyn
mock-consensus: 🫛 two_validators adds two keys
56c67ca 
fixes #3937.

* #3937
* #3588

this adds a `two_validators` method to the test node builder, so that
tests may set up a test node that has two validator keys.
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cratelyn cratelyn

Labels
A-mock-consensus Area: Relates to the mock consensus engine
Projects
Penumbra
Archived in project
Milestone
Sprint 4
Development

Successfully merging a pull request may close this issue.

mock-consensus: 🫛 two_validators adds two keys penumbra-zone/penumbra
1 participant
@cratelyn