Skip to content

Commit

Permalink
ci: add cargo-release to deps (#4960)
Browse files Browse the repository at this point in the history
## Describe your changes

<!--
Describe what's changed and why. If interactive testing is required,
explain
to the reviewer how the PR should be tested.
-->

## Issue ticket number and link
Adds two more packages to the nix dev again:

  * cargo-release
  * buf

Both of those tools are critical during release-engineering, so I'm
adding them to provide a deterministic way to generate the necessary
build inputs.

In this commit the nix env switches to the recently published stable
release for 2024-11. That stable release pulls in `buf` version 1.47.0,
which is sufficiently recent to satisfy the "at least 1.32" stipulation
we've had in the docs [0] for a while now.

[0] https://guide.penumbra.zone/dev/protobuf#installing-buf

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > dev-only, does not change application source code. 
  
 ## Testing and review
 
If you want to verify behavior locally, following the docs for setting
up the nix dev env https://guide.penumbra.zone/dev/dev-env and then
check versions:
 
 ```
 ❯ buf --version
1.47.0

❯ cargo release --version
cargo-release 0.25.10
```

You should see _exactly_ those versions. Additionally, you should be able to run `just protos` and confirm no files were modified.
  • Loading branch information
conorsch authored Dec 14, 2024
1 parent c654809 commit e2b06a0
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
Binary file modified crates/cnidarium/src/gen/proto_descriptor.bin.no_lfs
Binary file not shown.
Binary file modified crates/proto/src/gen/proto_descriptor.bin.no_lfs
Binary file not shown.
8 changes: 4 additions & 4 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
description = "A nix development shell and build environment for penumbra";

inputs = {
nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";
# nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";
nixpkgs.url = "github:NixOS/nixpkgs/nixos-24.11";
flake-utils.url = "github:numtide/flake-utils";
rust-overlay = {
url = "github:oxalica/rust-overlay";
Expand Down Expand Up @@ -150,7 +151,9 @@
inherit LIBCLANG_PATH ROCKSDB_LIB_DIR;
inputsFrom = [ penumbra ];
packages = [
buf
cargo-nextest
cargo-release
cargo-watch
glibcLocales # for postgres initdb locale support
cometbft
Expand Down

0 comments on commit e2b06a0

Please sign in to comment.