Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Testnet 68 halted at height 100736, with an `.expect` here: https://github.com/penumbra-zone/penumbra/blob/1c99e24ad5cf1ecc2855849d66221ecec25f9235/crates/core/component/dex/src/component/dex.rs#L66 This hit an error bubbled up from here: https://github.com/penumbra-zone/penumbra/blob/1c99e24ad5cf1ecc2855849d66221ecec25f9235/crates/core/component/dex/src/component/router/route_and_fill.rs#L277 The error occurs in this method, which is only ever used at that callsite: https://github.com/penumbra-zone/penumbra/blob/1c99e24ad5cf1ecc2855849d66221ecec25f9235/crates/core/component/dex/src/swap_execution.rs#L18 It's a little unclear why that method has double fallibility. Unfortunately, the answer may not be easily determined. It was added here 9cd566d which indicates that there was previously an infallible `max_price`, but that code isn't included in the commit; the previous reference to an infallible `max_price` was added in this commit b4b2635 which doesn't have the impl either, so presumably it got mangled during rebasing. In any case, removing the double fallibility, as in this commit, allows committing block 100736 on testnet 68, which I verified by running this code against a local copy of a state snapshot.
- Loading branch information