Skip to content

Commit

Permalink
feat(app): 🎣 add missing Dex component hook (#4247)
Browse files Browse the repository at this point in the history
see #3739, and #4246.

while wiring up a pair of missing component hooks for the `Sct`
component, i found another (noöp) hook that we do not include in the
`App`'s control flow.

this isn't currently a bug, since `<Dex as Component>::begin_block()` is
a noöps but could easily lead to a surprising outcome in the future, if
more logic was introduced to that trait method.

#### checklist before requesting a review

- [x] if this code contains consensus-breaking changes, i have added the
"consensus-breaking" label. otherwise, i declare my belief that there
are not consensus-breaking changes, for the following reason:

> while this **does** change the control flow of consensus-critical
logic, this does **not**
change the execution of incoming data. the hooks introduced here are
noöps.
  • Loading branch information
cratelyn authored Apr 19, 2024
1 parent fae3d5f commit 7e8ff55
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions crates/core/app/src/app/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ impl App {
begin_block,
)
.await;
Dex::begin_block(&mut arc_state_tx, begin_block).await;
CommunityPool::begin_block(&mut arc_state_tx, begin_block).await;
Governance::begin_block(&mut arc_state_tx, begin_block).await;
Staking::begin_block(&mut arc_state_tx, begin_block).await;
Expand Down

0 comments on commit 7e8ff55

Please sign in to comment.