Skip to content

Commit

Permalink
ci: use apply rather than sync for deploys
Browse files Browse the repository at this point in the history
We recently added several new manifests to the regular deployments, and
since making this change, preview deploys occasionally get gummed up.
A manual 'apply' action run locally straightens it out. The long-term
solution should be more intelligent wait-for-ready logic in the deploy
actions, but until then, let's do the bare minimum to keep things
working smoothly.
  • Loading branch information
conorsch committed Nov 2, 2023
1 parent 862df29 commit 25c4e6f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions deployments/ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ function helm_uninstall() {
# as necessary. Will *not* replace certain durable resources like
# the LoadBalancer Service objects, which are annotated with helm.sh/resource-policy=keep.
function helm_install() {
# TODO: make sure helmfile is present in ci environemnt.
helmfile sync -f "$HELMFILE_MANIFEST" --args \
helmfile apply -f "$HELMFILE_MANIFEST" --args \
--set="image.tag=${PENUMBRA_VERSION}"
}

Expand Down

0 comments on commit 25c4e6f

Please sign in to comment.