Skip to content

Commit

Permalink
fix(summonerd): colorized cli output, via clap v3
Browse files Browse the repository at this point in the history
Downgrades clap in summonerd v4 -> v3, to match other CLI tooling.
Essentially reverts 7bb3e80.
With clap v3, there's extra whitespace between long-arg descriptions,
due to our use of long_about in summonerd help docs. A major downside
to clap v4 is colorized output doesn't appear to be supported for
derive-style (it may be for builder-style, but we don't use that).

There's upstream progress on stabling color support, but until then,
let's just stick with v3 and put up with the whitespace.
  • Loading branch information
conorsch authored and cronokirby committed Nov 1, 2023
1 parent a328db3 commit 23d4b4b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 98 deletions.
100 changes: 3 additions & 97 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tools/summonerd/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ askama = "0.11"
axum = "0.6"
bytes = "1"
camino = "1"
clap = { version = "4", features = ["derive", "env", "color"] }
clap = { version = "3", features = ["derive", "env", "color"] }
console-subscriber = "0.2"
decaf377 = "0.5"
futures = "0.3.28"
Expand Down

0 comments on commit 23d4b4b

Please sign in to comment.