Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

larva-patterns - Adds new kicker image support to the article kicker module. #873

Merged
merged 3 commits into from
Nov 19, 2024
Merged

larva-patterns - Adds new kicker image support to the article kicker module. #873

merged 3 commits into from
Nov 19, 2024

Conversation

marcagarcia
Copy link
Contributor

@marcagarcia marcagarcia commented Nov 18, 2024 •
edited
Loading

larva-patterns - Adds new kicker image support to the article kicker module.

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

Deploy preview for pmc-larva ready!

✅ Preview
https://pmc-larva-ppady51ee-penske-media-corp.vercel.app

Built with commit b626036.
This pull request is being automatically deployed with vercel-action

@marcagarcia marcagarcia marked this pull request as ready for review November 18, 2024 19:04
@marcagarcia marcagarcia changed the title Feature/br 3651 larva-patterns - Adds new kicker image support to the article kicker module. Nov 18, 2024
@marcagarcia marcagarcia merged commit daf510e into master Nov 19, 2024
3 checks passed
@marcagarcia marcagarcia deleted the feature/BR-3651 branch November 19, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsalvucci rsalvucci rsalvucci approved these changes

@shawncook shawncook shawncook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcagarcia @shawncook @rsalvucci