Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PASE-1716: Add link styles to tag list items #818

Merged
merged 6 commits into from
Sep 28, 2023

Conversation

shawncook
Copy link
Contributor

@shawncook shawncook commented Sep 22, 2023

Tag list links needed some basic universal styling. I added bold and brand primary hover.

If running local larva: localhost:3000/larva/modules/tag-list/

Demo from Variety:

links

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
pmc-larva ❌ Failed (Inspect) Sep 22, 2023 3:39pm

@shawncook shawncook merged commit 364ea56 into master Sep 28, 2023
2 of 3 checks passed
@shawncook shawncook deleted the feature/PASE-1716-link-styles branch September 28, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants