Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll to beginning of the comparison table. #355

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Scroll to beginning of the comparison table. #355

merged 4 commits into from
Jan 8, 2025

Conversation

gianfra-t
Copy link
Contributor

No issue created.

  • Scroll to the beginning of the fee comparison table upon click of the button and using the deep link.

Changes

  • Add an id to the overarchingFeeComparison div.
  • Use a state hook to detect when the FeeComparison element is visible, and only then scroll to it.

@netlify Netlify
Copy link

netlify bot commented Jan 7, 2025 •
edited
Loading

✅ Deploy Preview for pendulum-pay ready!

Name Link
🔨 Latest commit 8467926
🔍 Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/677e762acd55470008a6f3b4
😎 Deploy Preview https://deploy-preview-355--pendulum-pay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gianfra-t gianfra-t requested a review from a team January 7, 2025 17:16
ebma
ebma approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works, nice job 👍

src/components/FeeComparison/index.tsx Outdated Show resolved Hide resolved
ebma
ebma approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor @Sharqiewicz, let's go.

@ebma ebma merged commit d4ccf78 into polygon-prototype-staging Jan 8, 2025
5 checks passed
@ebma ebma deleted the scroll-fee-compare branch January 8, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharqiewicz Sharqiewicz Sharqiewicz approved these changes

@ebma ebma ebma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gianfra-t @ebma @Sharqiewicz