Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong use of evm account address for assethub offramp #327

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Fix wrong use of evm account address for assethub offramp #327

merged 9 commits into from
Dec 13, 2024

Conversation

ebma
Copy link
Member

@ebma ebma commented Dec 13, 2024 •
edited
Loading

  • Adjust SIWE for Substrate accounts

Closes #326.

@ebma ebma linked an issue Dec 13, 2024 that may be closed by this pull request
Fix wrong use of evm account address for AssetHub offramp #326
Closed
@netlify Netlify
Copy link

netlify bot commented Dec 13, 2024 •
edited
Loading

✅ Deploy Preview for pendulum-pay ready!

Name Link
🔨 Latest commit 96496f6
🔍 Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/675c728f4fabf60008516cac
😎 Deploy Preview https://deploy-preview-327--pendulum-pay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ebma ebma requested a review from a team December 13, 2024 16:32
@ebma ebma marked this pull request as ready for review December 13, 2024 16:32
gianfra-t
gianfra-t approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@gianfra-t gianfra-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍.

@ebma ebma merged commit 418f5e1 into polygon-prototype-staging Dec 13, 2024
5 checks passed
@ebma ebma deleted the 326-fix-wrong-use-of-evm-account-address-for-assethub-offramp branch December 13, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharqiewicz Sharqiewicz Sharqiewicz left review comments

@gianfra-t gianfra-t gianfra-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix wrong use of evm account address for AssetHub offramp
3 participants
@ebma @Sharqiewicz @gianfra-t