Don't show Terms And Conditions modal #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pendulum-pay ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
gianfra-t
approved these changes
Dec 12, 2024
ebma
reviewed
Dec 13, 2024
There was a problem hiding this comment.
At the moment, the 'Confirm' button stays disabled as long as the T&C checkbox is not checked. However, I think it would be better if it was enabled (assuming the other checks for eg the input amount pass) and clicking on it will highlight the T&C checkbox in red color or similar. I as a user might miss the checkbox as it's not super prominent, which is okay, but I might wonder why I cannot click on the Confirm button in that case.
ebma
approved these changes
Dec 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.