Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready: monitor the funding account of vortex #277

Conversation

Sharqiewicz
Copy link
Contributor

@Sharqiewicz Sharqiewicz commented Nov 13, 2024

🦈 🟢 PR

  • install @slack/web-api
  • add SLACK_WEB_HOOK_TOKEN env variable ⚠️
  • add funds monitoring for: moonbeam (GLMR), pendulum (EUR, USDC.axl, PEN), stellar (XLM)

@Sharqiewicz Sharqiewicz linked an issue Nov 13, 2024 that may be closed by this pull request
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for pendulum-pay ready!

Name Link
🔨 Latest commit e39acb9
🔍 Latest deploy log https://app.netlify.com/sites/pendulum-pay/deploys/676e99d81ca1b0000838e2f6
😎 Deploy Preview https://deploy-preview-277--pendulum-pay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sharqiewicz Sharqiewicz changed the title wip: monitor the funding account of vortex Ready: monitor the funding account of vortex Nov 14, 2024
@Sharqiewicz Sharqiewicz requested a review from a team November 14, 2024 10:48
@TorstenStueber
Copy link
Collaborator

@Sharqiewicz can you please merge or rebase the latest polygon-prototype-staging?

Copy link

github-actions bot commented Nov 14, 2024

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@slack/logger ADDED - 4.0.0
@slack/types ADDED - 2.14.0
@slack/web-api ADDED - 7.8.0
@types/retry ADDED - 0.12.0
axios UPDATED 1.6.8 1.7.9
is-electron ADDED - 2.2.2
p-finally ADDED - 1.0.0
p-queue ADDED - 6.6.2
p-retry ADDED - 4.6.2
p-timeout ADDED - 3.2.0
retry UPDATED 0.12.0 0.13.1

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, though I would appreciate if we add some mechanism that limits the number of duplicate messages emitted to one per .. 6 hours maybe? So we avoid spamming the channel. Each type of warning should have its own timer though.

signer-service/src/api/services/stellar.service.js Outdated Show resolved Hide resolved
signer-service/src/api/services/pendulum.service.js Outdated Show resolved Hide resolved
signer-service/src/api/services/pendulum.service.js Outdated Show resolved Hide resolved
signer-service/src/api/controllers/moonbeam.controller.js Outdated Show resolved Hide resolved
@Sharqiewicz
Copy link
Contributor Author

@pendulum-chain/devs Ready for review ✅

Copy link
Contributor

@gianfra-t gianfra-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Only left one small comment.

Did you test it or do we test locally first?

signer-service/src/api/services/pendulum.service.js Outdated Show resolved Hide resolved
@Sharqiewicz Sharqiewicz merged commit a88123d into polygon-prototype-staging Jan 3, 2025
5 checks passed
@ebma ebma deleted the 216-monitor-the-funding-account-of-vortex branch January 6, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor the funding account of Vortex
4 participants