-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Spacewalk mykobo prototype phase 1 #21
Conversation
…n/pendulum-pay into spacewalk-mykobo-prototype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nicely done.
Please change this PR so that it does not merge into main, but into some special branch that we use for the prototype, as specified in the original ticket (there I proposed offramp-prototype
).
This is just a prototype, so none of the following statements really matter for this code base. However, I want to already leave a few general comments as a reference for a future actual production implementation.
- To be consistent with our style and to adopt common TypeScript conventions, don't prefix Interfaces with "I", just use the normal name.
- I think we should optimize for colocation, particularly when it comes to CSS and therefore don't put the CSS code in an extra file; in my opinion the CSS framework that maximizes colocation is Tailwind.
- Most components will then only be a single file -> in this case I think we should not put them into an index.ts file inside a folder but keep it flat. At least when editing it is much easier to find a file just looking at the name on the tab.
- This PR replaces
bn.js
withbig.js
. Polkadot.js already comes withbn.js
, no need to add yet another big number library (parsing numbers with decimals is also straightforward without any libraries). We should strive to keep our npm dependencies as minimal as possible to lower the attack surface and keep the build small.
const server = new Horizon.Server(HORIZON_URL); | ||
const keypair = Keypair.fromSecret(secret); | ||
|
||
//loading the account should be enough check if the account exists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely!
I'm merging this already in order to be able to establish a good structure for branches and deployments. Let's address the comments in the next iterations. |
Closes #17.
This PR contains the first steps of the prototype, with the requirements for Phase 1.