Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Spacewalk mykobo prototype phase 1 #21

Merged
merged 23 commits into from
Apr 24, 2024

Conversation

gianfra-t
Copy link
Contributor

Closes #17.

This PR contains the first steps of the prototype, with the requirements for Phase 1.

Copy link

yarn.lock changes

Summary

Status Count
ADDED 20
UPDATED 8
DOWNGRADED 1
Click to toggle table visibility
Name Status Previous Current
@stellar/js-xdr ADDED - 3.1.1
@stellar/stellar-base ADDED - 11.0.1
@types/big.js ADDED - 6.2.2
ansi-escapes UPDATED 6.2.0 6.2.1
axios ADDED - 1.6.8
base32.js ADDED - 0.1.0
base64-js ADDED - 1.5.1
big.js ADDED - 6.2.1
bignumber.js ADDED - 9.1.2
buffer ADDED - 6.0.3
eventsource ADDED - 2.0.2
follow-redirects ADDED - 1.15.6
husky UPDATED 8.0.3 9.0.11
ieee754 ADDED - 1.2.1
lint-staged UPDATED 15.2.0 15.2.2
listr2 UPDATED 8.0.0 8.0.1
node-gyp-build UPDATED 4.6.0 4.8.0
npm-run-path UPDATED 5.1.0 5.3.0
proxy-from-env ADDED - 1.1.0
randombytes ADDED - 2.1.0
rfdc UPDATED 1.3.0 1.3.1
sha.js ADDED - 2.4.11
sodium-native ADDED - 4.1.1
stellar-base ADDED - 11.0.1
stellar-sdk ADDED - 11.3.0
string-width UPDATED 7.0.0 7.1.0
toml ADDED - 3.0.0
type-fest DOWNGRADED 3.13.1 0.21.3
urijs ADDED - 1.19.11

Copy link
Collaborator

@TorstenStueber TorstenStueber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nicely done.

Please change this PR so that it does not merge into main, but into some special branch that we use for the prototype, as specified in the original ticket (there I proposed offramp-prototype).

This is just a prototype, so none of the following statements really matter for this code base. However, I want to already leave a few general comments as a reference for a future actual production implementation.

  • To be consistent with our style and to adopt common TypeScript conventions, don't prefix Interfaces with "I", just use the normal name.
  • I think we should optimize for colocation, particularly when it comes to CSS and therefore don't put the CSS code in an extra file; in my opinion the CSS framework that maximizes colocation is Tailwind.
  • Most components will then only be a single file -> in this case I think we should not put them into an index.ts file inside a folder but keep it flat. At least when editing it is much easier to find a file just looking at the name on the tab.
  • This PR replaces bn.js with big.js. Polkadot.js already comes with bn.js, no need to add yet another big number library (parsing numbers with decimals is also straightforward without any libraries). We should strive to keep our npm dependencies as minimal as possible to lower the attack surface and keep the build small.

const server = new Horizon.Server(HORIZON_URL);
const keypair = Keypair.fromSecret(secret);

//loading the account should be enough check if the account exists
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely!

@ebma ebma changed the base branch from main to offramp-prototype April 24, 2024 10:03
@ebma
Copy link
Member

ebma commented Apr 24, 2024

I'm merging this already in order to be able to establish a good structure for branches and deployments. Let's address the comments in the next iterations.

@ebma ebma merged commit 9996021 into offramp-prototype Apr 24, 2024
2 checks passed
@ebma ebma deleted the spacewalk-mykobo-prototype-phase-1 branch April 24, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phase 1 of Offramp prototype Pendulum -> Spacewalk -> Stellar Mykobo
3 participants