Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change all enum strings to lower case #32

Open
grizz opened this issue Oct 26, 2018 · 6 comments
Open

change all enum strings to lower case #32

grizz opened this issue Oct 26, 2018 · 6 comments
Assignees
Labels
Minor Up to 4 hours Requires Notice Implementing this ticket requires user be notified

Comments

@grizz
Copy link
Member

grizz commented Oct 26, 2018

Some of them, like region, are proper nouns which should be capitalized, but that can be left for anything displaying the information.

I'm for lowercasing everything as a rule, although I wonder if that should be a version 3 change for people matching against it?

@paravoid
Copy link
Contributor

paravoid commented May 1, 2020

#29 extends this, as capitalization in the verbose field names is also similar (e.g. "Traffic Levels").

@grizz grizz added Minor Up to 4 hours Requires Notice Implementing this ticket requires user be notified labels Aug 25, 2020
@grizz
Copy link
Member Author

grizz commented Sep 4, 2020

@peeringdb/pc please vote

@grizz grizz added this to the 1 Decide milestone Sep 4, 2020
@arnoldnipper
Copy link

What's the reasoning to lowercase everything?

@grizz
Copy link
Member Author

grizz commented Sep 11, 2020

Because it's the easiest way to standardize / normalize everything. These aren't the values that are displayed, they're the values stored in the db, so it's really just to make the API use easier.

@ynbrthr
Copy link

ynbrthr commented Sep 11, 2020

+1

@grizz
Copy link
Member Author

grizz commented Sep 25, 2020

@peeringdb/pc still need one more vote!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Up to 4 hours Requires Notice Implementing this ticket requires user be notified
Projects
None yet
Development

No branches or pull requests

4 participants