Rename empty choice option from Not Disclosed to Not Available

[paravoid]

OK, I expect this to a) be controversial, b) to have to wait for the "new translation server" (like in #24), but here goes anyway:

For a lot of the choice fields, the choices are:

    ('', _('Not Disclosed')),
    ('Not Disclosed', _('Not Disclosed')),

This is confusing, and results in e.g. search forms that look like this:

I'd argue that it would be better to rename the former to "Not Available", as that's what it really is, right? Thoughts?

[ Also, while we're here... why the Camel Case capitalization on this and other strings (such as "Not Required", "Heavy Outbound" etc.)? ]

[grizz]

I think they're both the same, we should just normalize down to "" for it -- that's leftover cruft from PDBv1

@peeringdb/pc thoughts?

[mcmanuss8]

+1 normalize to empty string

[mcmanuss8]

(RE: Camel Casing, I would fork that to a new issue @paravoid - that's more controversial ;)

[grizz]

I missed the camel casing thing on the end (and it's not camel casing per se, it's just capitalized words) -- created #32

[arnoldnipper]

+1 normalize to empty string

[paravoid]

Ping!

[arnoldnipper]

Shouldn't that be in peeringdb instead of django-peeringdb?

[paravoid]

The ambiguous constant mapping is in this project, under const.py:

RATIOS = (
    ("", _("Not Disclosed")),
    ("Not Disclosed", _("Not Disclosed")),
[…]

If that needs to be normalized so then… yeah, probably cross-project effort.

[grizz]

@arnoldnipper as @paravoid said, but the peeringdb project uses this code, so it's only here.