-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add absenceManagersId #147
Conversation
Update faker
This reverts commit 8aabe78.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Que-tin Personally I think it should be called absenceManagerIds
since it's an array of multiple ids. Maybe we want to clarify that with the backend team. Besides that: Looks good 👍
But its the an array of ids of multiple managers.
So I'd say first is correct even tho I agree it sounds a bit odd. P.s. I don't have rights to merge stuff. |
My array naming algorithm is as follows:
😁 I think both |
Naming wont be changes as of now. |
# [23.2.0](v23.1.0...v23.2.0) (2023-11-29) ### Features * Add absenceManagersId ([#147](#147)) ([a2fc3f0](a2fc3f0))
No description provided.