Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added users default holidaycount and targethours #137

Merged
merged 5 commits into from
Dec 4, 2023
Merged

feat: added users default holidaycount and targethours #137

merged 5 commits into from
Dec 4, 2023

Conversation

dsumer
Copy link
Collaborator

@dsumer dsumer commented Oct 12, 2023

No description provided.

@dsumer dsumer requested a review from jhnns October 19, 2023 14:10
jhnns
jhnns approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@jhnns jhnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself is good (hence approve) but I don't agree with the spelling of defaultTargetHours

src/models/user.ts Show resolved Hide resolved
@dsumer dsumer changed the title WIP: feat: added users default holidaycount and targethours feat: added users default holidaycount and targethours Dec 4, 2023
@dsumer dsumer merged commit e96713d into main Dec 4, 2023
3 checks passed
@dsumer dsumer deleted the new-default-usersettings branch December 4, 2023 13:33
github-actions bot pushed a commit that referenced this pull request Dec 4, 2023
@semantic-release-bot
chore(release): 23.5.0 [skip ci]
c392680 
# [23.5.0](v23.4.0...v23.5.0) (2023-12-04)

### Features

* added users default holidaycount and targethours ([2439f40](2439f40))
* added users default holidaycount and targethours ([#137](#137)) ([e96713d](e96713d))
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

🎉 This PR is included in version 23.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhnns jhnns jhnns approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsumer @jhnns