Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to PHP 8 #7

Merged
merged 11 commits into from
Dec 22, 2024
Merged

Port to PHP 8 #7

merged 11 commits into from
Dec 22, 2024

Conversation

duboism
Copy link
Contributor

@duboism duboism commented Nov 29, 2024

This PR ports the code to PHP 8 (including PHP 8.4).

For now we use the master branch of Image_Color from https://github.com/duboism/Image_Canvas/ because we need a version that runs on PHP 8. This has to be changed before merging. This was changed in 3b4d483.

What was changed

  • correct constructor
  • several functions have been declared static
  • correct a call to implode

@Neustradamus
Copy link

@duboism: "Image_Colorfrom" bad text ^^

It must be:

Hope that @ashnazg will add "Issues" section in specified repos...

@duboism
Copy link
Contributor Author

duboism commented Dec 1, 2024

@duboism: "Image_Colorfrom" bad text ^^

It must be:

* https://github.com/pear/Image_Color

Good catch. Corrected.

@ashnazg
Copy link
Member

ashnazg commented Dec 7, 2024

@duboism , looks good to me... go ahead and undo the master/repo addition in composer.json, and I'll get it merged after.

@ashnazg ashnazg self-assigned this Dec 7, 2024
composer.json Outdated Show resolved Hide resolved
@duboism
Copy link
Contributor Author

duboism commented Dec 7, 2024

@ashnazg, thanks for your time. The problem is that the latest tag on pear/image_color (1.0.6) is not compatible with PHP 8.

I have described this on PEAR ML in the (long) thread titled "Port Image_Color and Image_Canvas to PHP8": after the latest PRs, Image_Color works on PHP 8 so one just need to create a new tag and publish it on packagist and then I can finish this PR. Could you do that ?

@ashnazg
Copy link
Member

ashnazg commented Dec 8, 2024

@duboism , I've generated new release Image-Color-1.0.7, so you can now do your update here.

@duboism
Copy link
Contributor Author

duboism commented Dec 8, 2024

@ashnazg, I did it (see 3b4d483). I will edit the description and remove the draft status.

@duboism duboism marked this pull request as ready for review December 8, 2024 18:10
@duboism
Copy link
Contributor Author

duboism commented Dec 8, 2024

OK, I think everything is ready to merge now.

@duboism duboism requested a review from ashnazg December 14, 2024 16:21
@ashnazg ashnazg merged commit 7720e94 into pear:master Dec 22, 2024
11 checks passed
@ashnazg
Copy link
Member

ashnazg commented Dec 22, 2024

Included in v0.5.0 release.

@Neustradamus
Copy link

Thanks to @duboism for this PR and @ashnazg for merging and the new release build!

@duboism
Copy link
Contributor Author

duboism commented Dec 23, 2024

Thanks @ashnazg for merging this and for the tag.

@duboism duboism deleted the port_php8 branch December 23, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants