-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to PHP 8 #7
Conversation
We're almost done
Good catch. Corrected. |
@duboism , looks good to me... go ahead and undo the master/repo addition in |
@ashnazg, thanks for your time. The problem is that the latest tag on pear/image_color (1.0.6) is not compatible with PHP 8. I have described this on PEAR ML in the (long) thread titled "Port Image_Color and Image_Canvas to PHP8": after the latest PRs, Image_Color works on PHP 8 so one just need to create a new tag and publish it on packagist and then I can finish this PR. Could you do that ? |
@duboism , I've generated new release Image-Color-1.0.7, so you can now do your update here. |
OK, I think everything is ready to merge now. |
Included in v0.5.0 release. |
Thanks @ashnazg for merging this and for the tag. |
This PR ports the code to PHP 8 (including PHP 8.4).
For now we use the master branch of Image_Color from https://github.com/duboism/Image_Canvas/ because we need a version that runs on PHP 8. This has to be changed before merging.This was changed in 3b4d483.What was changed
implode