Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PHPStan run on CI #13

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Make PHPStan run on CI #13

merged 2 commits into from
Jul 21, 2024

Conversation

matsuo
Copy link
Collaborator

@matsuo matsuo commented Jul 20, 2024

This PR adds a CI job with phpstan (level 0) and I will resolve everything until it's green.

@till
Copy link
Member

till commented Jul 20, 2024

@matsuo I merged the other, so feel free to rebase this, e.g. if pear is the origin remote:

git fetch origin
git rebase origin/master

@matsuo
Copy link
Collaborator Author

matsuo commented Jul 20, 2024

Thanks for your kindness!
After adding “const ERROR_INVALID_PARAM_TYPE = 106;” to File/IMC.php, the detection result by PHPStan at level 0 is gone.

@CloCkWeRX CloCkWeRX merged commit 7b0750c into pear:master Jul 21, 2024
5 checks passed
@matsuo matsuo deleted the phpstan branch July 21, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants