Feat/1205528919110616 slashing liveness fault

node/src/parachain/dev_chain_spec.rs

@@ -133,6 +133,7 @@ fn configure_genesis(
 		parachain_staking: ParachainStakingConfig {
 			stakers,
 			max_candidate_stake: staking::MAX_COLLATOR_STAKE,
+			slashing_enabled: true,
 		},
 		inflation_manager: Default::default(),
 		block_reward: BlockRewardConfig {

node/src/parachain/krest_chain_spec.rs

@@ -118,6 +118,7 @@ fn configure_genesis(
 		parachain_staking: ParachainStakingConfig {
 			stakers,
 			max_candidate_stake: staking::MAX_COLLATOR_STAKE,
+			slashing_enabled: true,
 		},
 		inflation_manager: Default::default(),
 		block_reward: BlockRewardConfig {

node/src/parachain/peaq_chain_spec.rs

@@ -122,6 +122,7 @@ fn configure_genesis(
 		parachain_staking: ParachainStakingConfig {
 			stakers,
 			max_candidate_stake: staking::MAX_COLLATOR_STAKE,
+			slashing_enabled: true,
 		},
 		inflation_manager: Default::default(),
 		block_reward: BlockRewardConfig {

pallets/parachain-staking/src/lib.rs

@@ -519,6 +519,15 @@ pub mod pallet {
 		/// The commission for a collator has been changed.
 		/// \[collator's account, new commission\]
 		CollatorCommissionChanged(T::AccountId, Permill),
+		/// A collator have been slashed
+		/// \[collator's account, amount slashed\]
+		CollatorSlashed(T::AccountId, BalanceOf<T>),
+		/// Slashing has been enabled/disabled
+		/// \[new slashing status\]
+		SlashingEnabledChanged(bool),
+		/// A collator was kicked out of the candidate pool because of malicious behavior
+		/// \[collator's account]
+		CollatorKicked(T::AccountId),
 	}
 
 	#[pallet::hooks]
@@ -534,7 +543,13 @@ pub mod pallet {
 			crate::migrations::on_runtime_upgrade::<T>()
 		}
 
-		fn on_finalize(_n: BlockNumberFor<T>) {
+		fn on_finalize(n: BlockNumberFor<T>) {
+			// Check if it's the first block of the round
+			let current_round = Self::round();
+			if SlashingEnabled::<T>::get() && current_round.first == n {
+				// Slash any collators that didn't author blocks in previous round
+				Self::get_collators_without_blocks(current_round.current - 1);
+			}
 			Self::payout_collator();
 		}
 	}
@@ -677,22 +692,33 @@ pub mod pallet {
 	pub(crate) type DelayedPayoutInfo<T: Config> =
 		StorageValue<_, DelayedPayoutInfoT<SessionIndex, BalanceOf<T>>, OptionQuery>;
 
+	// Slashing enabled/disabled option
+	#[pallet::storage]
+	#[pallet::getter(fn slashing_enabled)]
+	pub(crate) type SlashingEnabled<T> = StorageValue<_, bool, ValueQuery>;
+
 	#[pallet::genesis_config]
 	pub struct GenesisConfig<T: Config> {
 		pub stakers: GenesisStaker<T>,
 		pub max_candidate_stake: BalanceOf<T>,
+		pub slashing_enabled: bool,
 	}
 
 	impl<T: Config> Default for GenesisConfig<T> {
 		fn default() -> Self {
-			Self { stakers: Default::default(), max_candidate_stake: Default::default() }
+			Self {
+				stakers: Default::default(),
+				max_candidate_stake: Default::default(),
+				slashing_enabled: true,
+			}
 		}
 	}
 
 	#[pallet::genesis_build]
 	impl<T: Config> BuildGenesisConfig for GenesisConfig<T> {
 		fn build(&self) {
 			MaxCollatorCandidateStake::<T>::put(self.max_candidate_stake);
+			SlashingEnabled::<T>::put(self.slashing_enabled);
 
 			// Setup delegate & collators
 			for &(ref actor, ref opt_val, balance) in &self.stakers {
@@ -1986,6 +2012,15 @@ pub mod pallet {
 			));
 			Ok(())
 		}
+
+		#[pallet::call_index(21)]
+		#[pallet::weight(<T as crate::pallet::Config>::WeightInfo::set_slashing_enabled())]
+		pub fn set_slashing_enabled(origin: OriginFor<T>, enabled: bool) -> DispatchResult {
+			ensure_root(origin)?;
+			SlashingEnabled::<T>::put(enabled);
+			Self::deposit_event(Event::SlashingEnabledChanged(enabled));
+			Ok(())
+		}
 	}
 
 	impl<T: Config> Pallet<T> {
@@ -2797,6 +2832,40 @@ pub mod pallet {
 			T::PotId::get().into_account_truncating()
 		}
 
+		// Get collators that didn't author blocks in previous round
+		fn get_collators_without_blocks(round: SessionIndex) {
+			let selected_candidates = Self::selected_candidates();
+			selected_candidates.into_iter().for_each(|collator| {
+				if !CollatorBlocks::<T>::contains_key(round, &collator) {
+					Self::kickout_faulty_collator(collator);
+				}
+			});
+		}
+
+		fn kickout_faulty_collator(collator: T::AccountId) {
+			let state = CandidatePool::<T>::get(&collator).expect("Collator must exist");
+			let mut candidates = TopCandidates::<T>::get();
+			if (candidates.len() as u32) <= T::MinRequiredCollators::get() {
+				return;
+			}
+
+			if Self::remove_candidate(&collator, &state).is_err() {
+				log::error!("Failed to remove collator {:?}", collator);
+			}
+
+			if candidates
+				.remove(&Stake { owner: collator.clone(), amount: state.total })
+				.is_some()
+			{
+				// update top candidates
+				TopCandidates::<T>::put(candidates);
+				// update total amount at stake from scratch
+				Self::update_total_stake();
+			};
+
+			Self::deposit_event(Event::CollatorKicked(collator));
+		}
+
 		/// Handles staking reward payout for previous session for one collator and their delegators
 		/// At Worst: 5 DB Reads and 'MaxSelectedCandidate + 1' DB Writes
 		/// Complexity: O(n)

pallets/parachain-staking/src/migrations.rs

@@ -2,13 +2,15 @@
 
 use crate::{
 	pallet::{Config, Pallet, OLD_STAKING_ID, STAKING_ID},
-	types::{Candidate, OldCandidate},
+	types::{AccountIdOf, Candidate, OldCandidate},
 	CandidatePool, ForceNewRound, Round,
 };
 use frame_support::{
-	pallet_prelude::{GetStorageVersion, StorageVersion},
+	pallet_prelude::{GetStorageVersion, StorageVersion, ValueQuery},
+	storage_alias,
 	traits::{Get, LockableCurrency, WithdrawReasons},
 	weights::Weight,
+	Twox64Concat,
 };
 use pallet_balances::Locks;
 use sp_runtime::Permill;
@@ -20,8 +22,9 @@ pub enum Versions {
 	_V8 = 8,
 	V9 = 9,
 	V10 = 10,
-	#[default]
 	V11 = 11,
+	#[default]
+	V12 = 12,
 }
 
 pub(crate) fn on_runtime_upgrade<T: Config>() -> Weight {
@@ -31,7 +34,11 @@ pub(crate) fn on_runtime_upgrade<T: Config>() -> Weight {
 mod upgrade {
 
 	use super::*;
+	use crate::pallet::SlashingEnabled;
 
+	#[storage_alias]
+	type CollatorBlock<T: Config> =
+		StorageMap<Pallet<T>, Twox64Concat, AccountIdOf<T>, u32, ValueQuery>;
 	/// Migration implementation that deletes the old reward rate config and changes the staking ID.
 	pub struct Migrate<T>(sp_std::marker::PhantomData<T>);
 
@@ -102,6 +109,21 @@ mod upgrade {
 
 				log::info!("V11 Migrating Done.");
 			}
+
+			if onchain_storage_version < StorageVersion::new(Versions::V12 as u16) {
+				log::info!(
+					"Running storage migration from version {:?} to {:?}",
+					onchain_storage_version,
+					Versions::default() as u16
+				);
+
+				// enable slashing
+				SlashingEnabled::<T>::put(true);
+				weight_writes += 1;
+
+				log::info!("V12 Migrating Done.");
+			}
+
 			// update onchain storage version
 			StorageVersion::new(Versions::default() as u16).put::<Pallet<T>>();
 			weight_writes += 1;

pallets/parachain-staking/src/mock.rs

@@ -278,9 +278,13 @@ impl ExtBuilder {
 		for delegator in self.delegators.clone() {
 			stakers.push((delegator.0, Some(delegator.1), delegator.2));
 		}
-		stake::GenesisConfig::<Test> { stakers, max_candidate_stake: 160_000_000 * DECIMALS }
-			.assimilate_storage(&mut t)
-			.expect("Parachain Staking's storage can be assimilated");
+		stake::GenesisConfig::<Test> {
+			stakers,
+			max_candidate_stake: 160_000_000 * DECIMALS,
+			slashing_enabled: true,
+		}
+		.assimilate_storage(&mut t)
+		.expect("Parachain Staking's storage can be assimilated");
 
 		// stashes are the AccountId
 		let session_keys: Vec<_> = self