feat: optional --range argument for cp to download single part of object #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackenzie-grimes-noaa
requested review from
seruman and
sonmezonur
and removed request for
a team
yetone
reviewed
Nov 26, 2024
| @@ -620,6 +621,9 @@ func (s *S3) Get( | |||
| if from.VersionID != "" { | |||
| input.VersionId = aws.String(from.VersionID) | |||
| } | |||
| if contentRange != nil { | |||
| input.Range = aws.String(*contentRange) | |||
| } | |||
|
|
|||
| return s.downloader.DownloadWithContext(ctx, to, input, func(u *s3manager.Downloader) { | |||
There was a problem hiding this comment.
Do you think I should use the Download() function from your screenshot instead of s.downloader.DownloadWithContext(...)? Since it does the same thing as the code in line 624 of s3.go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional string argument
--rangetocpcommand, which exposes the existing AWS GetObject Range header to provide a specific byterange of the object to be copied.Now s5cmd users can optionally set this header manually and only download a specific part of their src object.
Example:
Obviously makes any
--concurrencyor--part_sizearguments redundant when--rangeis specified, since only 1 part will be downloaded, using only 1 thread.Note: AWS GetObject only supports specifying a single byte range, so we are also constrained by this limitation. An s5cmd user would have to run multiple
cpcommands to download, for example, bytes ranging from 100-199 (bytes=100-199) and from 300-399 (bytes=300-399).Solves this Issue: #756