Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: implement logging to file #723

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rkhomenko
Copy link

Hello. First of all I want to thank you for a great tool.

I often use this program from Python using a subprocess.run function. I capture the stdout and stderr streams for error handling. Unfortunately, the progress bar for the command s5cmd cp is also output to the stderr stream, and I would like to capture all the output of the s5cmd and output the progress bar to the console at the same time.

This small PR adds the ability to log to a file, which will allow error handling and progress bar output.

@rkhomenko rkhomenko requested a review from a team as a code owner June 10, 2024 08:05
@rkhomenko rkhomenko requested review from ilkinulas and denizsurmeli and removed request for a team June 10, 2024 08:05
@rkhomenko rkhomenko force-pushed the feature/log-to-file branch from 00f902d to 876e360 Compare June 10, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant