Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support of Python 3.8 #3298

Merged
merged 8 commits into from
Nov 22, 2024
Merged

Conversation

huxuan
Copy link
Contributor

@huxuan huxuan commented Nov 16, 2024

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fix #3287

@huxuan huxuan changed the title feat: drop Python 3.8 support feat: drop support of Python 3.8 Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (d1dc03d) to head (560e81f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3298      +/-   ##
==========================================
- Coverage   85.33%   85.32%   -0.01%     
==========================================
  Files         112      112              
  Lines       11402    11396       -6     
  Branches     2487     2485       -2     
==========================================
- Hits         9730     9724       -6     
  Misses       1143     1143              
  Partials      529      529              
Flag Coverage Δ
unittests 85.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@huxuan huxuan marked this pull request as ready for review November 16, 2024 12:04
@huxuan huxuan marked this pull request as draft November 16, 2024 12:05
@huxuan huxuan marked this pull request as ready for review November 16, 2024 13:06
@frostming frostming merged commit fdcc750 into pdm-project:main Nov 22, 2024
21 checks passed
@frostming
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support of Python 3.8
2 participants