Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Adding CODEOWNERS #18

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Conversation

tangkong
Copy link
Contributor

@tangkong tangkong commented Oct 4, 2024

(autogenerated) Adding codeowners

@tangkong tangkong requested a review from ZLLentz October 4, 2024 19:09
@tangkong
Copy link
Contributor Author

tangkong commented Oct 4, 2024

This was autogenerated but I want to test some behavior I can't quite find docs on

CODEOWNERS Outdated
@@ -0,0 +1,6 @@
# Default owners are pcds-platforms-development
* @pcdshub/pcds-platform-development
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly use a less disruptive team for the tests

Suggested change
* @pcdshub/pcds-platform-development
* @pcdshub/test-team

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we needed to ping the whole formerly known as platforms team for our purposes here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make a test-team that just has @robert-test-tk on it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just make test-tk the default owner here, no need to test the teams quite yet. I just want to see what happens when we have multiple file types

@tangkong tangkong requested a review from ZLLentz October 4, 2024 21:43
@tangkong tangkong merged commit bb4fde6 into pcdshub:main Oct 4, 2024
6 of 9 checks passed
@tangkong tangkong deleted the mnt_add_codeowners branch December 20, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants