Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update engine-mode and version in optional file #68

Merged
merged 2 commits into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
Use this URL for the source of the module. See the usage examples below for more details.

```hcl
github.com/pbs/terraform-aws-rds-module?ref=0.4.0
github.com/pbs/terraform-aws-rds-module?ref=x.y.z
```

### Alternative Installation Methods
Expand All @@ -28,7 +28,7 @@ Integrate this module like so:

```hcl
module "rds" {
source = "github.com/pbs/terraform-aws-rds-module?ref=0.4.0"
source = "github.com/pbs/terraform-aws-rds-module?ref=x.y.z"

# Required Parameters
private_hosted_zone = "example.local"
Expand All @@ -47,7 +47,7 @@ module "rds" {

If this repo is added as a subtree, then the version of the module should be close to the version shown here:

`0.4.0`
`x.y.z`

Note, however that subtrees can be altered as desired within repositories.

Expand Down
14 changes: 12 additions & 2 deletions optional.tf
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,18 @@ variable "engine_mode" {
default = "provisioned"
type = string
validation {
condition = var.engine_mode != "serverless"
error_message = "This module does not support Aurora Serverless v1. Please switch to Aurora Serverless v2 instead by leaving this value set to the default value."
condition = var.engine_mode == "provisioned" || var.engine_mode == "serverless"
error_message = "This module supports only Aurora provisioned or Serverless v2. Please set engine_mode to 'serverless' for Serverless v2 or 'provisioned' for provisioned mode."
}
}

variable "engine_version" {
description = "Engine version of the RDS cluster"
default = "14.6" # Use a valid version for Serverless v2
type = string
validation {
condition = (var.engine_version >= "13.7" && var.engine_version <= "13.7") || (var.engine_version >= "14" && var.engine_version <= "15")
error_message = "Ensure the engine version is compatible with Aurora PostgreSQL versions that support Serverless v2 (>= 13.7 or 14.x)."
}
}

Expand Down