Skip to content

Commit

Permalink
Changes to readme. Removed reference to ad units from settings.
Browse files Browse the repository at this point in the history
  • Loading branch information
pbrisson committed Apr 10, 2018
1 parent 3dcfa0a commit 7fe03f9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ Setting | Description | Default
`DFP_USE_EXISTING_ORDER_IF_EXISTS` | Whether we should modify an existing order if one already exists with name `DFP_ORDER_NAME` | `False`
`DFP_NUM_CREATIVES_PER_LINE_ITEM` | The number of duplicate creatives to attach to each line item. Due to [DFP limitations](https://support.google.com/dfp_sb/answer/82245?hl=en), this should be equal to or greater than the number of ad units you serve on a given page. | the length of setting `DFP_TARGETED_PLACEMENT_NAMES`
`DFP_CURRENCY_CODE` | The currency to use in line items. | `'USD'`
`DFP_ALLOW_NO_INVENTORY_TARGETING` | If no placement should be used, for example for a run of network. If True, DFP_TARGETED_PLACEMENT_NAMES still need to be set to an empty array. | `False`
`PREBID_BIDDER_PARAMS` | Whether DFP targeting keys should be created following Bidders' Params structure. This is used when it's required to send all bids to the ad server. | `False`

## Limitations

Expand Down
5 changes: 2 additions & 3 deletions settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,8 @@
},
]

# If no placement or ad unit should be used, for example if the user wants a run
# of network. If True, DFP_TARGETED_PLACEMENT_NAMES and DFP_TARGETED_ADUNIT_NAMES
# still need to be set to empty arrays.
# If no placement should be used, for example for a run of network. If True,
# DFP_TARGETED_PLACEMENT_NAMES still need to be set to an empty array.
DFP_ALLOW_NO_INVENTORY_TARGETING = False

# Whether we should create the advertiser in DFP if it does not exist.
Expand Down

0 comments on commit 7fe03f9

Please sign in to comment.