Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove real time updates #25

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Remove real time updates #25

merged 1 commit into from
Mar 27, 2024

Conversation

martinbonnin
Copy link
Collaborator

Real time updates of the votes are suprising because:

  1. they change the UI without user interaction
  2. there is a few seconds of latency between the moment the userVote is sent and the moment the sessionVotes aggregate is updated by the cloud function client side which can make it look like the dots are blinking.

All in all, just get the state once when the composable starts and use a local state after that.

@martinbonnin martinbonnin merged commit 12b9c5a into main Mar 27, 2024
1 of 2 checks passed
@martinbonnin martinbonnin deleted the remove-live-update branch March 27, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinbonnin