Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tools): add pfe cli #2336

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from
Draft

feat(tools): add pfe cli #2336

wants to merge 47 commits into from

Conversation

bennypowers
Copy link
Member

@bennypowers bennypowers commented Feb 2, 2023 •
edited
Loading

What I did

  • add pfe cli
    • generate|new: same as create-element
    • analyze: generate custom-elements.json
    • create React wrappers with @lit-labs/react or some such (npm)
    • add demos to CEM in analzyer post-processing
    • lint changesets
  • move guts of the generator to pfe-tools

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 92373b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@patternfly/create-element Patch
@patternfly/pfe-tools Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added generator Updates relating to the generator tools Development and build tools labels Feb 2, 2023
@github-actions github-actions bot added the AT passed Automated testing has passed label Feb 2, 2023
@bennypowers bennypowers added this to the PatternFly Elements 2.x milestone Feb 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 3a37058
😎 Deploy Preview https://deploy-preview-2336--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@bennypowers bennypowers marked this pull request as draft August 10, 2023 14:40
@github-actions github-actions bot added work in progress POC / Not ready for review functionality Functionality, typically pertaining to the JavaScript. labels Aug 22, 2023
@bennypowers
Copy link
Member Author

I'm pretty happy with how the analyzer works so far. It could use some TUI polish, and is still missing the demos, but once the next version of lit analyzer releases we'll be in range

@bennypowers
fix(pfe-cli): write demo info to manifests
0c6784d
@bennypowers
chore(elements): fix tsconfig
9a82bc6
@bennypowers
fix(pfe-cli): clean up output
f5d067f
@bennypowers
fix(pfe-cli): help text for analyze
4020a6a
@bennypowers
chore: update deps
15192db
@bennypowers
chore: sort contributors
bc57277
@bennypowers
feat: lint changesets
0373c38
@bennypowers
chore: test runner ignores
69e2bd6
@bennypowers
style: lint
02c71fd
@bennypowers
fix: just make markdown lint an eslint thing
e1a5ba3
@bennypowers
fix(core): use browser globals (typescript)
1c77b6b 
prevents compile-time overload with incompatible nodeJS globals
@bennypowers
fix(pfe-cli): clean up output
6765fee 
shuffle files around
use package imports
fix some typescript errors
@bennypowers
fix(elements): move declaration from monorepo root
6514189 
fixes some esoteric analyzer bugs
@bennypowers
fix(pfe-cli): shuffle files, fixes
aeb5f87
@bennypowers
chore: better wireit for analyze
9478632
@bennypowers
fix(pfe-cli): edge cases to export-maps hack
0231855
@bennypowers
refactor(pfe-tools)!: remove 11ty cem templates
92373b8
@github-actions github-actions bot added the doc label Sep 1, 2023
@markcaron markcaron removed the doc label Sep 15, 2023
@bennypowers bennypowers removed this from the PatternFly Elements 2.x milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. generator Updates relating to the generator tools Development and build tools work in progress POC / Not ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennypowers @markcaron