fix(popover): add outsideClick event on popover show (#2514)

* fix(popover): add outsideClick event on popover show * docs: create perfect-rockets-approve.md --------- Co-authored-by: Anuj Singla <[email protected]> Co-authored-by: Benny Powers <[email protected]>
patternfly · Jun 16, 2023 · 2ba0b43 · 2ba0b43
1 parent 78f3333
commit 2ba0b43
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changeset/perfect-rockets-approve.md b/.changeset/perfect-rockets-approve.md
@@ -0,0 +1,5 @@
+---
+"@patternfly/elements": patch
+---
+
+`<pf-popover>`: prevent memory leak by removing event listeners event on popover close
diff --git a/elements/pf-popover/pf-popover.ts b/elements/pf-popover/pf-popover.ts
@@ -321,7 +321,6 @@ export class PfPopover extends LitElement {
   connectedCallback() {
     super.connectedCallback();
     this.addEventListener('keydown', this.onKeydown);
-    PfPopover.instances.add(this);
   }
 
   render() {
@@ -454,6 +453,7 @@ export class PfPopover extends LitElement {
     });
     this._popover?.show();
     this.dispatchEvent(new PopoverShownEvent());
+    PfPopover.instances.add(this);
   }
 
   /**
@@ -464,6 +464,7 @@ export class PfPopover extends LitElement {
     await this.#float.hide();
     this._popover?.close();
     this.dispatchEvent(new PopoverHiddenEvent());
+    PfPopover.instances.delete(this);
   }
 }