Added missing includes and comment on assert in find_occluding_edge_c…

…orrespondences()
patrikhuber · Apr 14, 2023 · 72aff97 · 72aff97
1 parent 8196a74
commit 72aff97
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/include/eos/fitting/closest_edge_fitting.hpp b/include/eos/fitting/closest_edge_fitting.hpp
@@ -23,6 +23,7 @@
 #define EOS_CLOSEST_EDGE_FITTING_HPP
 
 #include "eos/core/Mesh.hpp"
+#include "eos/core/math.hpp" // for sign()
 #include "eos/morphablemodel/EdgeTopology.hpp"
 #include "eos/fitting/RenderingParameters.hpp"
 #include "eos/render/normals.hpp"
@@ -280,6 +281,7 @@ inline std::pair<std::vector<Eigen::Vector2f>, std::vector<int>> find_occluding_
     const fitting::RenderingParameters& rendering_parameters, const std::vector<Eigen::Vector2f>& image_edges,
     float distance_threshold = 64.0f, bool perform_self_occlusion_check = true)
 {
+    // Note: I think we can potentially remove this assert. We check for different CameraTypes further below.
     assert(rendering_parameters.get_camera_type() == fitting::CameraType::Orthographic);
     using Eigen::Vector2f;
     using std::vector;

diff --git a/include/eos/fitting/contour_correspondence.hpp b/include/eos/fitting/contour_correspondence.hpp
@@ -32,6 +32,7 @@
 #include "toml.hpp"
 
 #include "Eigen/Core"
+#include "Eigen/Geometry" // for homogeneous()
 
 #include <vector>
 #include <string>