Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Fix for API token permissions throwing errors #31

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

argha-dot
Copy link
Collaborator

This is a PARTIAL fix for #28. It fixes the issue with not being able to grant super admin permissions to workspaces.

But when adding permissions for individual resources, it throws the following error:

image

The request being sent is

{
  "access_token": "token",
  "token_id": "76eca5505b4b468d907ef566ad6bae67",
  "token_name": "test-api-token",
  "token_exp": "2024-08-31",
  "token_nbf": "2024-08-14",
  "permissions": {
    "ad6ac6dff8644244b34d471d65523b50": {
      "type": "member",
      "13cf6790d91649b4873f5a980c5e93fe": {
        "permissionType": "exclude",
        "resources": []
      }
    }
  }
}

Now the issue (no puns) is I'm not able to verify whether the request I'm sending is faulty, or something is wrong with the server function, or the API function itself.

@rakshith-ravi
Copy link
Contributor

This is an API function flaw. Please open another issue for this, and we'll track it there. If this error is thrown, it means you're able to execute the API correctly.

@argha-dot argha-dot changed the title Parital Fix for API token permissions throwing errors WIP:Parital Fix for API token permissions throwing errors Aug 28, 2024
Fixed deleting a runner.
Fixed workspace list for API tokens
@rakshith-ravi rakshith-ravi merged commit 8e199a1 into develop Aug 29, 2024
@rakshith-ravi rakshith-ravi deleted the fix/api-token-issues branch August 29, 2024 18:35
@rakshith-ravi rakshith-ravi changed the title WIP:Parital Fix for API token permissions throwing errors Partial Fix for API token permissions throwing errors Aug 29, 2024
@argha-dot
Copy link
Collaborator Author

fixes #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants