Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sDAQC support for alternating layer ansatz #624

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Add sDAQC support for alternating layer ansatz #624

wants to merge 6 commits into from

Conversation

smitchaudhary
Copy link
Collaborator

Fixes #617

Following on from #565 add sDAQC strategy to Alt Ansatz constructor.

@smitchaudhary smitchaudhary self-assigned this Nov 27, 2024
@smitchaudhary smitchaudhary marked this pull request as draft November 27, 2024 11:42
@smitchaudhary
Copy link
Collaborator Author

Not fully ready yet. only refactored some code, haven't added the sDA version yet.

Summary so far:

  1. The 3 ansatze now live in 3 separate files instead of 2 of them in a singular big ansatze.py and the other in iia.py
  2. Created an alias iia for identity_initialized_ansatz so that it can be used in the same as hea and alt are available without renaming the original function to not break anything.

@jpmoutinho
Copy link
Collaborator

Thanks @smitchaudhary. I'll wait for you to ping me before doing a more thorough review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmoutinho jpmoutinho Awaiting requested review from jpmoutinho

At least 1 approving review is required to merge this pull request.

Assignees

@smitchaudhary smitchaudhary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Implement sDAQC strategy for Alt Ansatz
2 participants
@smitchaudhary @jpmoutinho