-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Time-dependent Hamevo with noise operators #621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chMoussa. I think it would be more consistent to stick to qadence blocks when it comes to interfaces asking for operators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chMoussa thanks for this ! Unsure about how it works though. I thought you had to specify operators but instead you seem to be passing a list of identities ?
@jpmoutinho @RolandMacDoland I modified eventually the code to work with a list of blocks as noise operators. We won't support certain cases such as parametric blocks but I left a warning note in docs about using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chMoussa, looking good. I think my main question now is about how general / restrictive should the noise model be. In Pulser only single-qubit jump operators are available. If we don't have that restriction, is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, final comment left on the docs but otherwise lgtm.
Closes #622 . Adding the
noise_operators
argument toHamevo
as in Pyqtorch.TODOs:
noise_operators
argument to HamevoNote that one may need to adapt the NoiseHandler class later to set the
noise_operators
accordingly to the type of analog noise. However, this may require harmonising all noises in all backends. Thus this is left for future work.