[Bug] Fix GPSR differentiation mode #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chMoussa
reviewed
Nov 19, 2024
chMoussa
approved these changes
Nov 19, 2024
chMoussa
added a commit
to pasqal-io/pyqtorch
that referenced
this pull request
Nov 19, 2024
Following this [Qadence MR](pasqal-io/qadence#616), where I quote @vytautas-a : `I suspect that due to some symmetries in matrices computed during GPSR calculations, results with some generators are not correct. Breaking this symmetry of shifts around pi/2 helps in this regard.` Changing the interval for multigap GPSR to not be symmetric. ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently GPSR differentiation mode with
pyqtorchbackend is not used even when it is selected. Alsoh_normfactor is used when parsing analog gates that is not correct. This PR fixes these issues.