Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Setting digital noise in addition to readout noise in Pyq backend functions sample and expectation #610

Merged
merged 19 commits into from
Nov 23, 2024
Merged

[Feature] Setting digital noise in addition to readout noise in Pyq backend functions sample and expectation #610

merged 19 commits into from
Nov 23, 2024

Conversation

chMoussa
Copy link
Collaborator

Complementing #591 and #599 where digital and readout noise can be set in the converted circuit from sample and expectation, without the user calling set_noise beforehand.

RolandMacDoland
RolandMacDoland reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chMoussa nice work. I think we might want to simplify and reorganise functionalities so that it makes the logic more understandable. WDYT ?

qadence/backends/pyqtorch/backend.py Outdated Show resolved Hide resolved
qadence/backends/pyqtorch/backend.py Outdated Show resolved Hide resolved
qadence/backends/pyqtorch/backend.py Outdated Show resolved Hide resolved
qadence/backends/pyqtorch/backend.py Outdated Show resolved Hide resolved
qadence/backends/pyqtorch/backend.py Outdated Show resolved Hide resolved
qadence/backends/pyqtorch/backend.py Outdated Show resolved Hide resolved
qadence/backends/pyqtorch/backend.py Outdated Show resolved Hide resolved
qadence/backends/pyqtorch/backend.py Outdated Show resolved Hide resolved
qadence/noise/protocols.py Outdated Show resolved Hide resolved
tests/qadence/test_noise/test_digital_noise.py Show resolved Hide resolved
mlahariya
mlahariya reviewed Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@mlahariya mlahariya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chMoussa, nice work. Looks alright to me. Just a minor typo.

qadence/backends/pyqtorch/convert_ops.py Outdated Show resolved Hide resolved
RolandMacDoland
RolandMacDoland reviewed Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chMoussa looks nice but I think there are bits and pieces that might be simplified. Happy to approve once addressed.

qadence/noise/protocols.py Outdated Show resolved Hide resolved
qadence/noise/protocols.py Outdated Show resolved Hide resolved
qadence/noise/protocols.py Outdated Show resolved Hide resolved
qadence/transpile/noise.py Outdated Show resolved Hide resolved
@chMoussa chMoussa self-assigned this Nov 21, 2024
@chMoussa chMoussa added the feature New feature or request label Nov 21, 2024
RolandMacDoland
RolandMacDoland approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chMoussa. LGTM. Minor comments.

qadence/noise/protocols.py Show resolved Hide resolved
qadence/transpile/noise.py Outdated Show resolved Hide resolved
@chMoussa @RolandMacDoland
Update qadence/transpile/noise.py
7185863 
Co-authored-by: RolandMacDoland <[email protected]>
@chMoussa chMoussa merged commit 8e3631d into main Nov 23, 2024
8 checks passed
@chMoussa chMoussa deleted the cm/call_setnoise_in_backend branch November 23, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlahariya mlahariya mlahariya left review comments

@RolandMacDoland RolandMacDoland RolandMacDoland approved these changes

@jpmoutinho jpmoutinho Awaiting requested review from jpmoutinho

Assignees

@chMoussa chMoussa

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chMoussa @RolandMacDoland @mlahariya @jpmoutinho