-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to the amplitude noise implementation #768
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -78,6 +78,8 @@ class Channel(ABC): | |||
min_avg_amp: The minimum average amplitude of a pulse (when not zero). | |||
mod_bandwidth: The modulation bandwidth at -3dB (50% reduction), in | |||
MHz. | |||
propagation_dir: The propagation direction of the beam leaving the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I am not a fan of "leaving", what about
propagation_dir: The propagation direction of the beam leaving the | |
propagation_dir: The propagation direction of the beam (or wave) associated with the |
Ah I forgot about one question: should we raise a NotImplementedError if the propagation vector is implemented in a channel that is not Rydberg.Global ? |
I think that is overly restrictive, how about I do that only for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Channel
laser_waist
betweenNoiseModel
andSimConfig
pulser_version
to serialized devicesNote: To avoid disruptions for serialized devices between different versions,
propagation_dir
is defaulting toNone
in all channels andQutipEmulator
is assuming usingpropagation_dir=(0,1,0)
whenever it encounterNone
. In a future version, it would make more sense to change the defaultpropagation_dir
ofGlobal
channels to be(0,1,0)
and remove this assumption fromQutipEmulator
.Fixes #712