Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding relaxation noise channel #675

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Adding relaxation noise channel #675

merged 4 commits into from
Apr 23, 2024

Conversation

HGSilveri
Copy link
Collaborator

The tutorials on noisy simulation should be updated accordingly but I'll leave that for another PR as I think we'll need to do a deeper revision. I'm still noting it down in #658 so we don't forget about it.

Closes #673 .

@HGSilveri HGSilveri requested a review from a-corni April 22, 2024 09:43
Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a plot of a Rabi with a T1 ? That would be my final check, otherwise it all looks good to me :)

Corresponds to 1/T2.
relaxation_rate: The rate of relaxation from the Rydberg to the
ground state (in 1/µs). Corresponds to 1/T1.
depolarizing_rate: The rate (in 1/µs) at which a depolarizing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are associating dephasing and relaxation rates with real rates - hence mapping noise types with real noises - should we raise a Warning for the depolarizing rate or add a note in the description of the depolarizing rate saying that this noise is not associated with any physical phenomenon in cold atoms ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add some more details in this docstring

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just add "Does not correspond to a physical noise." ?

@HGSilveri
Copy link
Collaborator Author

Do you have a plot of a Rabi with a T1 ? That would be my final check, otherwise it all looks good to me :)

For this sequence:

Figure_2

You get these occupations of the Rydberg state:

Figure_3

@a-corni
Copy link
Collaborator

a-corni commented Apr 23, 2024

Do you have a plot of a Rabi with a T1 ? That would be my final check, otherwise it all looks good to me :)

For this sequence:

Figure_2

You get these occupations of the Rydberg state:

Figure_3

Perfect ! The T1 matches with the slope

Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes !

@HGSilveri HGSilveri merged commit f303138 into develop Apr 23, 2024
7 checks passed
@HGSilveri HGSilveri deleted the hs/relaxation branch April 23, 2024 08:31
soufianekaghad98 pushed a commit to soufianekaghad98/Pulser that referenced this pull request Apr 25, 2024
* Adding relaxation noise channel

* Improving noise channel descriptions

* Switch relaxation and dephasing

* Rephrase depolarizing noise description
@HGSilveri HGSilveri mentioned this pull request Apr 29, 2024
HGSilveri added a commit that referenced this pull request Apr 29, 2024
Main changes:

21a47f3 Remove Register.rotate() (#642)
20e6765 FIX: Redefine slope of RampWaveform (#644)
c2d5b6c Enabling definition of multiple noise channels and noise channels in XY (#647)
bcb78cc Enable digital simulation (#652)
0f6e3dd Improve access to output modulation durations (#663)
188d21d Remove deprecated noise arguments (#674)
f303138 Adding relaxation noise channel (#675)
716b86b Centralize all backend imports from a single pulser.backends module (#678)
96a8c34 Add hyperfine dephasing rate to NoiseModel (#680)
4981ca6 Add optional default noise models to devices (#676)
c695373 Rectangular lattice register and layout (#665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "relaxation" noise
2 participants