-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding relaxation noise channel #675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a plot of a Rabi with a T1 ? That would be my final check, otherwise it all looks good to me :)
Corresponds to 1/T2. | ||
relaxation_rate: The rate of relaxation from the Rydberg to the | ||
ground state (in 1/µs). Corresponds to 1/T1. | ||
depolarizing_rate: The rate (in 1/µs) at which a depolarizing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are associating dephasing and relaxation rates with real rates - hence mapping noise types with real noises - should we raise a Warning for the depolarizing rate or add a note in the description of the depolarizing rate saying that this noise is not associated with any physical phenomenon in cold atoms ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add some more details in this docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps just add "Does not correspond to a physical noise." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes !
* Adding relaxation noise channel * Improving noise channel descriptions * Switch relaxation and dephasing * Rephrase depolarizing noise description
Main changes: 21a47f3 Remove Register.rotate() (#642) 20e6765 FIX: Redefine slope of RampWaveform (#644) c2d5b6c Enabling definition of multiple noise channels and noise channels in XY (#647) bcb78cc Enable digital simulation (#652) 0f6e3dd Improve access to output modulation durations (#663) 188d21d Remove deprecated noise arguments (#674) f303138 Adding relaxation noise channel (#675) 716b86b Centralize all backend imports from a single pulser.backends module (#678) 96a8c34 Add hyperfine dephasing rate to NoiseModel (#680) 4981ca6 Add optional default noise models to devices (#676) c695373 Rectangular lattice register and layout (#665)
The tutorials on noisy simulation should be updated accordingly but I'll leave that for another PR as I think we'll need to do a deeper revision. I'm still noting it down in #658 so we don't forget about it.
Closes #673 .