Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DMM, methods of RegisterLayout inherited from Traps, Result #587

Merged
merged 8 commits into from
Sep 27, 2023

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Sep 27, 2023

docs/source/apidoc/core.rst Show resolved Hide resolved
docs/source/apidoc/core.rst Outdated Show resolved Hide resolved
docs/source/apidoc/core.rst Show resolved Hide resolved
@HGSilveri
Copy link
Collaborator

Do you need help figuring out what's up with the RTD build?

@a-corni
Copy link
Collaborator Author

a-corni commented Sep 27, 2023

Do you need help figuring out what's up with the RTD build?

Well I have a Warning raised when asking to display QutipResult. At the moment I don't find a way to circumvent it.
image

@a-corni
Copy link
Collaborator Author

a-corni commented Sep 27, 2023

I think it's coming from this attribute:
image

@HGSilveri
Copy link
Collaborator

Do you need help figuring out what's up with the RTD build?

Well I have a Warning raised when asking to display QutipResult. At the moment I don't find a way to circumvent it. image

QubitId is just a type alias, try to import it in qutip_result.py (and add an ignore to the flake8 error):

from pulser.register import QubitId   # noqa: F401

@a-corni
Copy link
Collaborator Author

a-corni commented Sep 27, 2023

Do you need help figuring out what's up with the RTD build?

Well I have a Warning raised when asking to display QutipResult. At the moment I don't find a way to circumvent it. image

QubitId is just a type alias, try to import it in qutip_result.py (and add an ignore to the flake8 error):

from pulser.register import QubitId   # noqa: F401

Ah okay I did it differently by making explicit the first two attributes... Is this fine by you or do you prefer your method ?

@HGSilveri
Copy link
Collaborator

Do you need help figuring out what's up with the RTD build?

Well I have a Warning raised when asking to display QutipResult. At the moment I don't find a way to circumvent it. image

QubitId is just a type alias, try to import it in qutip_result.py (and add an ignore to the flake8 error):

from pulser.register import QubitId   # noqa: F401

Ah okay I did it differently by making explicit the first two attributes... Is this fine by you or do you prefer your method ?

What you did is fine, let's see if it works

Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@HGSilveri HGSilveri merged commit b51a23d into develop Sep 27, 2023
6 checks passed
@HGSilveri HGSilveri deleted the add_dmm_result_api branch September 27, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API reference updates
2 participants