Fix for DSM-Auto Bind on Lemon-RX Gen2 #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with multiple brands (Spektrum, OrangeRX, Lemon-Rx, Admiral). Even some old DSM 2 receivers. All work with "Auto" now. Just in case one needs a LONG bind sending period, when not using "Auto" works the same as before.
frankiearzu
changed the title
|
Hi Frankie, I think we should not differentiate bind and auto. Let's reduce overall the timing since you've tested on multiple RXs. We will see how to address the issues if they ever arise. |
Removed the short and long bind count logic.
|
Done! left the debug statements since they could be useful in the future. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #916
Tested with multiple brands (Spektrum, OrangeRX, Lemon-Rx, Admiral). Even some old DSM 2 receivers.
Lemon-RX needed a short Bind Send period (180 count, about 1.8s instead of 3s)
All brands works with "Auto" now. Just in case one needs a LONG bind sending period, when not using "Auto" works the same as before.