Sometimes we have missing data passed to the objet, deal with it

pascalchevrel · Nov 3, 2024 · a94cfb4 · a94cfb4
1 parent 72100f2
commit a94cfb4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/pchevrel/BzKarma/Scoring.php b/src/pchevrel/BzKarma/Scoring.php
@@ -140,8 +140,13 @@ class Scoring
     public function __construct(array $bugsDetails, int $release)
     {
         // Replace numeric keys by the real bug number
-        $bugsDetails = $bugsDetails['bugs'];
-        $this->bugsDetails = array_combine(array_column($bugsDetails, 'id'), $bugsDetails);
+        if (isset($bugsDetails['bugs'])) {
+            $bugsDetails = $bugsDetails['bugs'];
+            $this->bugsDetails = array_combine(array_column($bugsDetails, 'id'), $bugsDetails);
+        } else {
+            $this->bugsDetails = [];
+        }
+
         $this->release = strval($release);
         $this->beta    = strval($this->release + 1);
         $this->nightly = strval($this->release + 2);

diff --git a/tests/Unit/BzKarma/ScoringTest.php b/tests/Unit/BzKarma/ScoringTest.php
@@ -16,6 +16,10 @@
         ->toBe('131');
     expect($obj->nightly)
         ->toBe('132');
+
+    $obj = new Scoring([], 130);
+    expect($obj->bugsDetails)
+        ->toBe([]);
 });
 
 test('Scoring->getBugScoreDetails()', function () use ($obj) {