-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
추천한 항목을 취소할 수 있습니다 #32 #33
Open
mmx900
wants to merge
1
commit into
parti-coop:master
Choose a base branch
from
mmx900:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,19 @@ | ||
- if user_signed_in? && current_user.voted_for?(votable) | ||
= link_to '#', class: "mr-1" do | ||
%i.far.fa-heart | ||
= votable.votes_for.size | ||
- else | ||
- path = user_signed_in? ? vote_article_path(votable) : '#' | ||
= link_to path, method: :put, remote: true, class: "#{dom_id(votable)}_vote_btn text-muted text-nowrap mr-1" do | ||
%i.far.fa-heart | ||
= votable.votes_for.size | ||
%div{ class: "#{dom_id(votable)}_vote_btn d-flex align-items-end" } | ||
- if user_signed_in? && current_user.voted_for?(votable) | ||
- path = votable.user_id == current_user.id ? '#' : vote_article_path(votable) | ||
= link_to path, method: :put, remote: true, class: "mr-1" do | ||
%i.far.fa-heart | ||
= votable.votes_for.size | ||
- else | ||
- path = user_signed_in? ? vote_article_path(votable) : '#' | ||
= link_to path, method: :put, remote: true, class: "text-muted text-nowrap mr-1" do | ||
%i.far.fa-heart | ||
= votable.votes_for.size | ||
|
||
%small.text-muted.ml-1 | ||
%span.font-weight-bold>= link_to votable.user.name, votable.user, class: 'text-dark' | ||
님 추천 | ||
- if votable.votes_for.size > 1 | ||
· | ||
= votable.votes_for.reject{|vote| vote.voter_id == votable.user_id }.collect {|vote| vote.voter.name }.join(', ') | ||
님 공감 | ||
%small.text-muted.ml-1 | ||
%span.font-weight-bold>= link_to votable.user.name, votable.user, class: 'text-dark' | ||
님 추천 | ||
- if votable.votes_for.size > 1 | ||
· | ||
= votable.votes_for.reject{|vote| vote.voter_id == votable.user_id }.collect {|vote| vote.voter.name }.join(', ') | ||
님 공감 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 모르니 로그인 여부를 먼저 확인하면 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드에 참고할만한 내용을 못 찾아서, 가이드를 주시면 좋겠는데요.
그냥 위에
return unless user_signed_in?
한 줄 추가하면 될까요?혹시 프레임웍을 사용중이거나 더 나은 방법이 있나 싶어서 여쭙니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issues/app/controllers/comments_controller.rb
Line 2 in d4cec45
이것처럼 하되 여기에 only: [:vote] 옵션을 주는 식으면 어떠려나요?