Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

추천한 항목을 취소할 수 있습니다 #32 #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/controllers/articles_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ def show
end

def vote
@article.liked_by current_user
if current_user.voted_for? @article
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 모르니 로그인 여부를 먼저 확인하면 어떨까요?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드에 참고할만한 내용을 못 찾아서, 가이드를 주시면 좋겠는데요.
그냥 위에 return unless user_signed_in? 한 줄 추가하면 될까요?
혹시 프레임웍을 사용중이거나 더 나은 방법이 있나 싶어서 여쭙니다.

Copy link

@dalikim dalikim May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before_action :authenticate_user!

이것처럼 하되 여기에 only: [:vote] 옵션을 주는 식으면 어떠려나요?

@article.unliked_by current_user
else
@article.liked_by current_user
end
end

def create
Expand Down
34 changes: 18 additions & 16 deletions app/views/votes/_btn.html.haml
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
- if user_signed_in? && current_user.voted_for?(votable)
= link_to '#', class: "mr-1" do
%i.far.fa-heart
= votable.votes_for.size
- else
- path = user_signed_in? ? vote_article_path(votable) : '#'
= link_to path, method: :put, remote: true, class: "#{dom_id(votable)}_vote_btn text-muted text-nowrap mr-1" do
%i.far.fa-heart
= votable.votes_for.size
%div{ class: "#{dom_id(votable)}_vote_btn d-flex align-items-end" }
- if user_signed_in? && current_user.voted_for?(votable)
- path = votable.user_id == current_user.id ? '#' : vote_article_path(votable)
= link_to path, method: :put, remote: true, class: "mr-1" do
%i.far.fa-heart
= votable.votes_for.size
- else
- path = user_signed_in? ? vote_article_path(votable) : '#'
= link_to path, method: :put, remote: true, class: "text-muted text-nowrap mr-1" do
%i.far.fa-heart
= votable.votes_for.size

%small.text-muted.ml-1
%span.font-weight-bold>= link_to votable.user.name, votable.user, class: 'text-dark'
님 추천
- if votable.votes_for.size > 1
·
= votable.votes_for.reject{|vote| vote.voter_id == votable.user_id }.collect {|vote| vote.voter.name }.join(', ')
님 공감
%small.text-muted.ml-1
%span.font-weight-bold>= link_to votable.user.name, votable.user, class: 'text-dark'
님 추천
- if votable.votes_for.size > 1
·
= votable.votes_for.reject{|vote| vote.voter_id == votable.user_id }.collect {|vote| vote.voter.name }.join(', ')
님 공감