Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Convert to ESM #2306

Draft
wants to merge 21 commits into
base: alpha
Choose a base branch
from

Conversation

damianstasik
Copy link
Contributor

@damianstasik damianstasik commented Oct 1, 2022

New Pull Request Checklist

Issue Description

Related issue: #FILL_THIS_OUT

Pre-flight checklist

  • webpack starts and works, all build types work as expected
  • babel compiles files properly
  • dashboard starts, no errors & no new warnings in the console
  • PIG starts, lists all components, everything is interactive as it was
  • jest starts, tests complete
  • linting does not crash, lints issues if there are any
  • bin script still works
  • dashboard can be imported as regular module (in a custom express setup)
  • semantic release works (blocked by ES Modules semantic-release/semantic-release#2133)
  • node version checker works
  • code generators do not crash, generates proper & updated code
  • no module.exports nor requires in the code
  • package-json check works
  • circular dependency finder works

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 1, 2022

Thanks for opening this pull request!

  • ❌ Please fill out all fields with a placeholder FILL_THIS_OUT, otherwise your pull request will be closed. If a field does not apply to the pull request, fill in n/a.

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title refactor: convert to ESM refactor: Convert to ESM Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant