Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul of Parse Server Guide #809

Open
wants to merge 29 commits into
base: gh-pages
Choose a base branch
from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jan 4, 2021

This PR is intended to replace the README of the Parse Server repo, ensuring that all documentation is in one place.

I personally think that the README of the Parse Server repo should be stripped back to capture what Parse Server is about in a few lines, and then point to the docs for the most updated references.

Not sure if we want the contributors / sponsors on the site as well - I think it's a nice touch.

Closes #808

@dblythy
Copy link
Member Author

dblythy commented Jan 31, 2021

Any further comments around this PR @TomWFox 😊

@TomWFox
Copy link
Contributor

TomWFox commented Feb 1, 2021

I kind of thought I'd submitted a review on this but clearly not, it's still pending!

@dblythy
Copy link
Member Author

dblythy commented Feb 1, 2021

No worries @TomWFox. No rush at all. If you have bulk changes suggested I can happily share my branch with you.

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats what I've got so far...

_includes/parse-server/adapters.md Outdated Show resolved Hide resolved
_includes/parse-server/backers.md Outdated Show resolved Hide resolved
_includes/parse-server/bleeding-edge.md Outdated Show resolved Hide resolved
_includes/parse-server/experimental.md Outdated Show resolved Hide resolved
_includes/parse-server/experimental.md Outdated Show resolved Hide resolved
_includes/parse-server/logging.md Outdated Show resolved Hide resolved
_includes/parse-server/logging.md Outdated Show resolved Hide resolved
_includes/parse-server/upgrading-to-v3.md Outdated Show resolved Hide resolved
_includes/parse-server/usage.md Outdated Show resolved Hide resolved
_includes/parse-server/graphql.md Show resolved Hide resolved
@dblythy
Copy link
Member Author

dblythy commented Feb 10, 2021

Before merging, I'll have to go back through again and add changes to the GitHub readme, such as Localization.

_includes/parse-server/experimental.md Outdated Show resolved Hide resolved
@TomWFox
Copy link
Contributor

TomWFox commented Feb 10, 2021

I have looked it all over now so we're getting there 😀

@dblythy
Copy link
Member Author

dblythy commented Feb 11, 2021

I've added Localization but I couldn't get the table to format. Are markdown tables supported or do we need to reformat?

@mtrezza
Copy link
Member

mtrezza commented Feb 11, 2021

Keep the empty lines before and after the table. Empty lines are missing at many places of the Localization part that you pasted. Try to keep the content and copy/paste without much modification, because empty lines are important in MD.

@dblythy
Copy link
Member Author

dblythy commented Feb 11, 2021

Thanks! My mac must have removed them in the copy/paste bc I don't think I deliberately removed them.

Anyway, here's how the table looks now. Any ideas as to how to optimize?

Screen Shot 2021-02-11 at 12 33 34 pm

@mtrezza
Copy link
Member

mtrezza commented Feb 11, 2021

Table formatting for the GitHub MD interpreter is a topic on its own - but it's possible. If you're interested, see here why.

@TomWFox
Copy link
Contributor

TomWFox commented Feb 11, 2021

Markdown tables are not fun, learnt that the hard way!

Edit: feel free to play around with it but my guess is that a different format will work best here

@mtrezza
Copy link
Member

mtrezza commented Feb 11, 2021

I agree with different format, like in the API docs. I also think this would be better placed in the docs than in the README.

@TomWFox
Copy link
Contributor

TomWFox commented Feb 12, 2021

Is this ready for another review?

@dblythy
Copy link
Member Author

dblythy commented Feb 12, 2021

Yes plz 👍

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few wee bits...

_includes/parse-server/experimental.md Outdated Show resolved Hide resolved
_includes/parse-server/experimental.md Outdated Show resolved Hide resolved
_includes/parse-server/experimental.md Outdated Show resolved Hide resolved
_includes/parse-server/experimental.md Outdated Show resolved Hide resolved
_includes/parse-server/experimental.md Outdated Show resolved Hide resolved
Comment on lines 57 to 61

| Parameter | Optional | Type | Default value | Example values | Environment variable | Description |
|----------------------------|----------|-----------------|---------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `idempotencyOptions` | yes | `Object` | `undefined` | | PARSE_SERVER_EXPERIMENTAL_IDEMPOTENCY_OPTIONS | Setting this enables idempotency enforcement for the specified paths. |
| `idempotencyOptions.paths` | yes | `Array<String>` | `[]` | `.*` (all paths, includes the examples below), <br>`functions/.*` (all functions), <br>`jobs/.*` (all jobs), <br>`classes/.*` (all classes), <br>`functions/.*` (all functions), <br>`users` (user creation / update), <br>`installations` (installation creation / update) | PARSE_SERVER_EXPERIMENTAL_IDEMPOTENCY_PATHS | An array of path patterns that have to match the request path for request deduplication to be enabled. The mount path must not be included, for example to match the request path `/parse/functions/myFunction` specifiy the path pattern `functions/myFunction`. A trailing slash of the request path is ignored, for example the path pattern `functions/myFunction` matches both `/parse/functions/myFunction` and `/parse/functions/myFunction/`. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have lost some of the extra info provided in this table.

@mtrezza you're better placed to comment on the importance of this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have been no changes to the feature, the table's content should remain.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe hold off addressing this until #809 (comment) has been resolved

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good restructuring, just some formatting...


The following parameter and placeholder keys are reserved because they are used related to features such as password reset or email verification. They should not be used as translation keys in the JSON resource or as manually defined placeholder keys in the configuration: `appId`, `appName`, `email`, `error`, `locale`, `publicServerUrl`, `token`, `username`.

### Parameters
Copy link
Member

@mtrezza mtrezza Feb 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in favor of this format, IMO harder to read than the table. Can we find something better visually structured? Edit: I am referring to the "Parameters" paragraph.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially naive question - is this something that is or can be documented in the api reference?

@@ -0,0 +1,9 @@
# Want to ride the bleeding edge?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need an extra page for 1 sentence?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could perhaps remove this entirely as it's 'how to use npm packages' info rather than 'how to use Parse Server'.

Anyone that doesn't know about how to use the master branch before reading this probably shouldn't be anyway.

_includes/parse-server/experimental.md Outdated Show resolved Hide resolved
_includes/parse-server/experimental.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Parse Server Guide for Email Options, Account Lockout, PasswordPolicy 📕
3 participants