Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make leaves and nodes tmp files paths platform independent #296

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

StepanWorkV
Copy link
Contributor

On windows graphviz throws cannot find file exceptions.
This is due to the hardcoded unix-style.

Example: C:\Users\username\AppData\Local\Temp/leaf191_25772.svg

@parrt
Copy link
Owner

parrt commented Jun 2, 2023

@tlapusan looks ok to me. You?

@parrt parrt added this to the 2.2.3 milestone Jun 2, 2023
@tlapusan
Copy link
Collaborator

tlapusan commented Jun 6, 2023

Sorry for late response, just got back from vacation...

@parrt it look good for me also. Pulled the PR and double checked that it works also :). Curious how it worked until now on windows ?!

@StepanWorkV thanks for this PR. A very good improved to the library ! Hope that you enjoy using it 👍

@StepanWorkV
Copy link
Contributor Author

StepanWorkV commented Jun 6, 2023

Sorry for late response, just got back from vacation...

@parrt it look good for me also. Pulled the PR and double checked that it works also :). Curious how it worked until now on windows ?!

@StepanWorkV thanks for this PR. A very good improved to the library ! Hope that you enjoy using it 👍

Thanks!
It worked because on windows "/" can be in file name, thus when a file was generated it was stored as Temp/leaf191_25772.svg (just my guess, didn't verify that).

BTW please take a look at this issue, I have created that PR while trying to resolve it:
#298
(It didn't solve it though, I have provided some comments why, please let me know if you need some additional clarity)

@tlapusan
Copy link
Collaborator

@parrt I think we are good to merge this PR

@parrt parrt added the clean up label Jun 30, 2023
@parrt parrt merged commit b7279ec into parrt:master Jun 30, 2023
@parrt parrt modified the milestones: 2.2.3, 2.2.2 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants