Skip to content

Inherents and empty block production overhaul #241

Inherents and empty block production overhaul

Inherents and empty block production overhaul #241

Triggered via pull request May 9, 2024 12:17
Status Cancelled
Total duration 21m 21s
Artifacts

rust-checks.yaml

on: pull_request
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 1 warning
called `map(..).flatten()` on `Option`: core/src/inherents/custom_idps/para_parachain.rs#L35
error: called `map(..).flatten()` on `Option` --> core/src/inherents/custom_idps/para_parachain.rs:35:10 | 35 | .map(|b| -> Option<u32> { Decode::decode(&mut &b[..]).ok() }) | __________^ 36 | | .flatten() | |__________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|b| -> Option<u32> { Decode::decode(&mut &b[..]).ok() })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten = note: `-D clippy::map-flatten` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::map_flatten)]`
called `map(..).flatten()` on `Option`: core/src/inherents/custom_idps/para_parachain.rs#L51
error: called `map(..).flatten()` on `Option` --> core/src/inherents/custom_idps/para_parachain.rs:51:10 | 51 | .map(|b| -> Option<NumberFor<B>> { Decode::decode(&mut &b[..]).ok() }) | __________^ 52 | | .flatten() | |__________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|b| -> Option<NumberFor<B>> { Decode::decode(&mut &b[..]).ok() })` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
useless conversion to the same type: `sp_timestamp::Timestamp`: core/src/inherents/custom_idps/timestamp.rs#L33
error: useless conversion to the same type: `sp_timestamp::Timestamp` --> core/src/inherents/custom_idps/timestamp.rs:33:46 | 33 | Some((prev_inherent_data, _)) => sp_timestamp::InherentDataProvider::new( | ______________________________________________^ 34 | | prev_inherent_data 35 | | .timestamp_inherent_data() 36 | | .unwrap() ... | 40 | | .timestamp() 41 | | .into(), | |___________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]` help: consider removing `.into()` | 33 ~ Some((prev_inherent_data, _)) => sp_timestamp::InherentDataProvider::new( 34 + prev_inherent_data 35 + .timestamp_inherent_data() 36 + .unwrap() 37 + .unwrap() 38 + + self.blocktime_millis, 39 + ) 40 ~ .timestamp(), |
useless conversion to the same type: `sp_timestamp::Timestamp`: core/src/inherents/custom_idps/timestamp.rs#L42
error: useless conversion to the same type: `sp_timestamp::Timestamp` --> core/src/inherents/custom_idps/timestamp.rs:42:21 | 42 | None => sp_timestamp::InherentDataProvider::from_system_time() | _____________________^ 43 | | .timestamp() 44 | | .into(), | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 42 ~ None => sp_timestamp::InherentDataProvider::from_system_time() 43 ~ .timestamp(), |
lint
Clippy had exited with the 101 exit code
test (ubuntu-latest, stable)
Canceling since a higher priority waiting request for 'refs/pull/86/merge-Rust checks' exists
test (ubuntu-latest, stable)
The operation was canceled.
doc
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: arduino/setup-protoc@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.