build: Install toolchains #228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarkkojs
force-pushed
the
install-toolchains
branch
from
5e6a197
to
a6896f2
Compare
Add toolchains to rust-toolchain.xml so that they don't need to be installed manually with "rustup add component". This further simplifies the build, in addition to linker supplying the polkavm custom targets. Start with the minimal profile, and add only mandatory components for the build. On a fresh Rust install, this will result: $ cargo b info: syncing channel updates for '1.75.0-aarch64-apple-darwin' info: latest update on 2023-12-28, rust version 1.75.0 (82e1608df 2023-12-21) info: downloading component 'cargo' info: downloading component 'clippy' info: downloading component 'rust-std' info: downloading component 'rust-std' for 'wasm32-wasi' info: downloading component 'rust-std' for 'x86_64-unknown-none' info: downloading component 'rustc' info: downloading component 'rustfmt' info: installing component 'cargo' info: installing component 'clippy' info: installing component 'rust-std' info: installing component 'rust-std' for 'wasm32-wasi' info: installing component 'rust-std' for 'x86_64-unknown-none' info: installing component 'rustc' info: installing component 'rustfmt' Signed-off-by: Jarkko Sakkinen <[email protected]>
jarkkojs
force-pushed
the
install-toolchains
branch
from
a6896f2
to
439394c
Compare
|
Incorrect workspace; this should be in If you want to add targets for the Also, we don't use the wasi target for WASM anywhere. |
|
OK fair enough! I'll close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add toolchains to rust-toolchain.xml so that they don't need to be installed manually with
rustup add component. This further simplifies the build, in addition to linker supplying the polkavm custom targets. Start with the minimal profile, and add only mandatory components for the build.On a fresh Rust install, this will result: