Replace duplicated whitelist with whitelisted_storage_keys #7024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiweiii
commented
Jan 1, 2025
bkchr
approved these changes
Jan 1, 2025
|
@qiweiii it doesn't compile. I think you forgot to import the trait. |
auto-merge was automatically disabled
January 3, 2025 12:58
Head branch was pushed to by a user without write access
|
Review required! Latest push from author must always be reviewed |
seadanda
reviewed
Jan 3, 2025
| //TODO: use from relay_well_known_keys::ACTIVE_CONFIG | ||
| hex_literal::hex!("06de3d8a54d27e44a9d5ce189618f22db4b49d95320d9021994c850f25b8e385").to_vec().into(), | ||
| ]; | ||
| use frame_support::traits::WhitelistedStorageKeys; |
There was a problem hiding this comment.
This should go at the head of the file with the other use statements
There was a problem hiding this comment.
No. This here is guarded by the runtime-benchmarks feature and we have here multiple imports.
ggwpez
approved these changes
Jan 3, 2025
bkchr
approved these changes
Jan 3, 2025
Merged
via the queue into
paritytech:master
with commit Jan 3, 2025
0b4f131
197 of 201 checks passed
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
…h#7024) related issue: paritytech#7018 replaced duplicated whitelists with `AllPalletsWithSystem::whitelisted_storage_keys();` in this PR --------- Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #7018
replaced duplicated whitelists with
AllPalletsWithSystem::whitelisted_storage_keys();in this PR