Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pallet-bounties: Fix benchmarks for 0 ED #7013

Merged
merged 3 commits into from
Dec 30, 2024
Merged

pallet-bounties: Fix benchmarks for 0 ED #7013

merged 3 commits into from
Dec 30, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Dec 29, 2024

Closes: #7009

@bkchr bkchr added T1-FRAME This PR/Issue is related to core FRAME, the framework. A4-needs-backport Pull request must be backported to all maintained releases. labels Dec 29, 2024
@bkchr bkchr requested a review from gui1117 December 29, 2024 22:05
@bkchr bkchr requested a review from a team as a code owner December 29, 2024 22:05
@bkchr
Copy link
Member Author

bkchr commented Dec 30, 2024

/cmd prdoc --audience runtime_dev --bump patch

@bkchr bkchr enabled auto-merge December 30, 2024 09:58
@bkchr bkchr added this pull request to the merge queue Dec 30, 2024
@luispdm luispdm mentioned this pull request Dec 30, 2024
Open
Merged via the queue into master with commit 997db8e Dec 30, 2024
198 of 201 checks passed
@bkchr bkchr deleted the bkchr-bounties-zero-ed branch December 30, 2024 11:06
@paritytech-cmd-bot-polkadot-sdk
Copy link

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7013-to-stable2407
git worktree add --checkout .worktree/backport-7013-to-stable2407 backport-7013-to-stable2407
cd .worktree/backport-7013-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 997db8e2035ce180f502ccb54eb06ab464d95dab
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Dec 30, 2024
Draft
@paritytech-cmd-bot-polkadot-sdk
Copy link

Created backport PR for stable2409:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7013-to-stable2409
git worktree add --checkout .worktree/backport-7013-to-stable2409 backport-7013-to-stable2409
cd .worktree/backport-7013-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 997db8e2035ce180f502ccb54eb06ab464d95dab
git push --force-with-lease

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Dec 30, 2024
Draft
github-actions bot pushed a commit that referenced this pull request Dec 30, 2024
@bkchr @github-actions
pallet-bounties: Fix benchmarks for 0 ED (#7013)
9d36a64 
Closes: #7009

---------

Co-authored-by: command-bot <>
(cherry picked from commit 997db8e)
@paritytech-cmd-bot-polkadot-sdk
Copy link

Successfully created backport PR for stable2412:

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Dec 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seadanda seadanda seadanda approved these changes

@gui1117 gui1117 gui1117 approved these changes

Assignees
No one assigned
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to properly benchmark pallet_bounties when ED is 0
3 participants
@bkchr @gui1117 @seadanda