Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: Send already connected peers to new subscribers #7011

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

dmitry-markin
Copy link
Contributor

Introduce SyncEvent::InitialPeers message sent to new subscribers to allow them correctly tracking sync peers. This resolves a race condition described in #6573 (comment).

Fixes #6573.

@dmitry-markin dmitry-markin added the T0-node This PR/Issue is related to the topic “node”. label Dec 27, 2024
@dmitry-markin dmitry-markin requested a review from bkchr December 27, 2024 16:54
@dmitry-markin
Copy link
Contributor Author

/cmd prdoc --audience node_dev --bump major

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

prdoc/pr_7011.prdoc Outdated Show resolved Hide resolved
@bkchr bkchr requested a review from a team December 28, 2024 19:57
Co-authored-by: Bastian Köcher <[email protected]>
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12536695325
Failed job name: test-linux-stable-no-try-runtime

@bkchr bkchr requested a review from skunert December 29, 2024 22:06
@dmitry-markin dmitry-markin added this pull request to the merge queue Dec 30, 2024
Merged via the queue into master with commit b4177a9 Dec 30, 2024
195 of 201 checks passed
@dmitry-markin dmitry-markin deleted the dm-sync-peers-state-event branch December 30, 2024 15:02
Copy link
Contributor

@pepoviola pepoviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @dmitry-markin 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
Status: Blocked ⛔️
Development

Successfully merging this pull request may close these issues.

Fix flaky zombienet test zombienet-cumulus-0002-pov_recovery
4 participants