tracing for logging in fatxpool #6897
Open
+163
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michalkucharczyk you said i should let you know when i start with a single file, #5490 (comment) |
…ng-log # Conflicts: # substrate/client/transaction-pool/Cargo.toml
bkchr
reviewed
Dec 28, 2024
Comment on lines
+278
to
+279
| let tx_hash_string = format!("{:?}", tx_hash); | ||
| debug!(tx_hash_string, "dropped_watcher: removing (non-tracked) tx"); |
There was a problem hiding this comment.
Suggested change
| let tx_hash_string = format!("{:?}", tx_hash); | |
| debug!(tx_hash_string, "dropped_watcher: removing (non-tracked) tx"); | |
| debug!(target: LOG_TARGET, ?tx_hash, "dropped_watcher: removing (non-tracked) tx"); |
| @@ -100,10 +100,10 @@ where | |||
| /// | |||
| /// `ready_iterator` is a closure that generates the result data to be sent to the pollers. | |||
| fn trigger(&mut self, at: Block::Hash, ready_iterator: impl Fn() -> T) { | |||
| log::trace!(target: LOG_TARGET, "fatp::trigger {at:?} pending keys: {:?}", self.pollers.keys()); | |||
| tracing::trace!(target: LOG_TARGET, "fatp::trigger {at:?} pending keys: {:?}", self.pollers.keys()); | |||
There was a problem hiding this comment.
Suggested change
| tracing::trace!(target: LOG_TARGET, "fatp::trigger {at:?} pending keys: {:?}", self.pollers.keys()); | |
| tracing::trace!(target: LOG_TARGET, ?at, keys = ?self.poller.keys(), "fatp::trigger"); |
| let Some(pollers) = self.pollers.remove(&at) else { return }; | ||
| pollers.into_iter().for_each(|p| { | ||
| log::debug!(target: LOG_TARGET, "trigger ready signal at block {}", at); | ||
| tracing::debug!(target: LOG_TARGET, "trigger ready signal at block {}", at); |
There was a problem hiding this comment.
Suggested change
| tracing::debug!(target: LOG_TARGET, "trigger ready signal at block {}", at); | |
| tracing::debug!(target: LOG_TARGET, ?at, "trigger ready signal", at); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the fatxpool to use tracing instead of log for logging.
closes #5490